From 2506007a6f25b24fa558282b48bcbcfc1c507954 Mon Sep 17 00:00:00 2001 From: Carson Fleming Date: Fri, 13 Jan 2023 04:27:14 -0800 Subject: Update comment about NPTY bug --- pkd_stub.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkd_stub.py b/pkd_stub.py index 1d33ddf..272f74a 100644 --- a/pkd_stub.py +++ b/pkd_stub.py @@ -359,11 +359,14 @@ def run_pty(screen, cn): try: data = screen.recv(1024) + # TODO: there is an artifact here due to use of blocking sockets: + # must hit 1 additional key before PTY mode will disable (because + # waiting for this recv.) This will be patched out when we switch + # to using selectors. if not alive: return False except: data = b'\xde\xad' - # TODO: problem is here: we wake up and suddenly not in pty mode if not data or data == b'\xde\xad': unpty(client) return False -- cgit v1.2.3